Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MPIJob unit tests to use spec.runPolicy.cleanPodPolicy #1556

Merged
merged 6 commits into from
Mar 20, 2022
Merged

Update MPIJob unit tests to use spec.runPolicy.cleanPodPolicy #1556

merged 6 commits into from
Mar 20, 2022

Conversation

cheimu
Copy link
Member

@cheimu cheimu commented Mar 20, 2022 •
edited
Loading

What this PR does / why we need it:
This pr update mpijob unit tests: in the past, unit tests uses spec.cleanPodPolicy to test gc logic, but now in training-operator framework, spec.runPolicy.CleanPodPolicy is the standard, so it is more suit to use this field in unit tests as well.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1555

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @cheimu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheimu cheimu changed the title Update MPIJob unit tests to use runPolicy.cleanPodPolicy instead of c… Update MPIJob unit tests to use spec.runPolicy.cleanPodPolicy Mar 20, 2022
terrytangyuan
terrytangyuan approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 20, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheimu, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheimu
Copy link
Member Author

cheimu commented Mar 20, 2022

@terrytangyuan Hi Terry, It's weird, I don't know why tfjobs tests got failed for this pr. As you can see, except MPIJobs, this pr has nothing else been modified, so I don't know why this could lead to other jobs' unit tests failed. Any ideas? :/ Thank you in advance!

image

image

@google-oss-prow google-oss-prow bot removed the lgtm label Mar 20, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot merged commit 8644f05 into kubeflow:master Mar 20, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2012430626

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.815%
Totals Coverage Status
Change from base Build 1996927612: 0.0%
Covered Lines: 2277
Relevant Lines: 6185
💛 - Coveralls

@cheimu
Copy link
Member Author

cheimu commented Mar 20, 2022

@terrytangyuan Hi Terry, It's weird, I don't know why tfjobs tests got failed for this pr. As you can see, except MPIJobs, this pr has nothing else been modified, so I don't know why this could lead to other jobs' unit tests failed. Any ideas? :/ Thank you in advance!

image image

Okay... Never minds, the unit tests got passed in the end :D

@cheimu cheimu mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@zw0610 zw0610 Awaiting requested review from zw0610

Assignees

@terrytangyuan terrytangyuan

Labels
approved needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we update MPIJob unit test CleanPodPolicy field?
4 participants
@cheimu @aws-kf-ci-bot @coveralls @terrytangyuan